fix(buf): disable which-key when recording a macro #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to get a better fix for this that would allow |
|
I was actually planning to look into this just now :) Your fix would have worked in most cases, but there could still possibly be issues with macro executing and re-attaching after the macro ended recording. Just fixed it for all those cases (I think). Thanks! |
|
Awesome thanks so much I like your approach much better! Could we also get a stable release tagged with this fix as well :) |
folke
pushed a commit
that referenced
this pull request
Sep 18, 2024
🤖 I have created a release *beep* *boop* --- ## [3.13.3](v3.13.2...v3.13.3) (2024-09-18) ### Bug Fixes * **config:** disable wk by default for terminal mode ([#825](#825)) ([e7b415c](e7b415c)) * **triggers:** never attach when macro is recording / executing. Fixes [#851](#851). Fixes [#822](#822). Fixes [#807](#807) ([6b023b4](6b023b4)) * **view:** display actual scroll up/down keys in help ([#821](#821)) ([dafe27a](dafe27a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Done! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently which-key breaks macro recording which makes keys get double recorded. This disables which-key while recording to restore this critical vim functionality.
Related Issue(s)